615 lines
18 KiB
Go
615 lines
18 KiB
Go
package vsphere
|
|
|
|
import (
|
|
"context"
|
|
"crypto/tls"
|
|
"net/url"
|
|
"os"
|
|
"strings"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/stretchr/testify/require"
|
|
"github.com/vmware/govmomi/object"
|
|
"github.com/vmware/govmomi/simulator"
|
|
"github.com/vmware/govmomi/vim25/mo"
|
|
"github.com/vmware/govmomi/vim25/types"
|
|
|
|
"github.com/influxdata/telegraf/config"
|
|
common_tls "github.com/influxdata/telegraf/plugins/common/tls"
|
|
"github.com/influxdata/telegraf/testutil"
|
|
)
|
|
|
|
func defaultVSphere() *VSphere {
|
|
return &VSphere{
|
|
Log: testutil.Logger{},
|
|
ClusterMetricInclude: []string{
|
|
"cpu.usage.*",
|
|
"cpu.usagemhz.*",
|
|
"mem.usage.*",
|
|
"mem.active.*"},
|
|
ClusterMetricExclude: nil,
|
|
ClusterInclude: []string{"/**"},
|
|
HostMetricInclude: []string{
|
|
"cpu.coreUtilization.average",
|
|
"cpu.costop.summation",
|
|
"cpu.demand.average",
|
|
"cpu.idle.summation",
|
|
"cpu.latency.average",
|
|
"cpu.readiness.average",
|
|
"cpu.ready.summation",
|
|
"cpu.swapwait.summation",
|
|
"cpu.usage.average",
|
|
"cpu.usagemhz.average",
|
|
"cpu.used.summation",
|
|
"cpu.utilization.average",
|
|
"cpu.wait.summation",
|
|
"disk.deviceReadLatency.average",
|
|
"disk.deviceWriteLatency.average",
|
|
"disk.kernelReadLatency.average",
|
|
"disk.kernelWriteLatency.average",
|
|
"disk.numberReadAveraged.average",
|
|
"disk.numberWriteAveraged.average",
|
|
"disk.read.average",
|
|
"disk.totalReadLatency.average",
|
|
"disk.totalWriteLatency.average",
|
|
"disk.write.average",
|
|
"mem.active.average",
|
|
"mem.latency.average",
|
|
"mem.state.latest",
|
|
"mem.swapin.average",
|
|
"mem.swapinRate.average",
|
|
"mem.swapout.average",
|
|
"mem.swapoutRate.average",
|
|
"mem.totalCapacity.average",
|
|
"mem.usage.average",
|
|
"mem.vmmemctl.average",
|
|
"net.bytesRx.average",
|
|
"net.bytesTx.average",
|
|
"net.droppedRx.summation",
|
|
"net.droppedTx.summation",
|
|
"net.errorsRx.summation",
|
|
"net.errorsTx.summation",
|
|
"net.usage.average",
|
|
"power.power.average",
|
|
"storageAdapter.numberReadAveraged.average",
|
|
"storageAdapter.numberWriteAveraged.average",
|
|
"storageAdapter.read.average",
|
|
"storageAdapter.write.average",
|
|
"sys.uptime.latest"},
|
|
HostMetricExclude: nil,
|
|
HostInclude: []string{"/**"},
|
|
VMMetricInclude: []string{
|
|
"cpu.demand.average",
|
|
"cpu.idle.summation",
|
|
"cpu.latency.average",
|
|
"cpu.readiness.average",
|
|
"cpu.ready.summation",
|
|
"cpu.run.summation",
|
|
"cpu.usagemhz.average",
|
|
"cpu.used.summation",
|
|
"cpu.wait.summation",
|
|
"mem.active.average",
|
|
"mem.granted.average",
|
|
"mem.latency.average",
|
|
"mem.swapin.average",
|
|
"mem.swapinRate.average",
|
|
"mem.swapout.average",
|
|
"mem.swapoutRate.average",
|
|
"mem.usage.average",
|
|
"mem.vmmemctl.average",
|
|
"net.bytesRx.average",
|
|
"net.bytesTx.average",
|
|
"net.droppedRx.summation",
|
|
"net.droppedTx.summation",
|
|
"net.usage.average",
|
|
"power.power.average",
|
|
"virtualDisk.numberReadAveraged.average",
|
|
"virtualDisk.numberWriteAveraged.average",
|
|
"virtualDisk.read.average",
|
|
"virtualDisk.readOIO.latest",
|
|
"virtualDisk.throughput.usage.average",
|
|
"virtualDisk.totalReadLatency.average",
|
|
"virtualDisk.totalWriteLatency.average",
|
|
"virtualDisk.write.average",
|
|
"virtualDisk.writeOIO.latest",
|
|
"sys.uptime.latest"},
|
|
VMMetricExclude: nil,
|
|
VMInclude: []string{"/**"},
|
|
DatastoreMetricInclude: []string{
|
|
"disk.used.*",
|
|
"disk.provisioned.*"},
|
|
DatastoreMetricExclude: nil,
|
|
DatastoreInclude: []string{"/**"},
|
|
ResourcePoolMetricInclude: []string{
|
|
"cpu.capacity.*",
|
|
"mem.capacity.*"},
|
|
ResourcePoolMetricExclude: nil,
|
|
ResourcePoolInclude: []string{"/**"},
|
|
DatacenterMetricInclude: nil,
|
|
DatacenterMetricExclude: nil,
|
|
DatacenterInclude: []string{"/**"},
|
|
ClientConfig: common_tls.ClientConfig{InsecureSkipVerify: true},
|
|
|
|
MaxQueryObjects: 256,
|
|
MaxQueryMetrics: 256,
|
|
ObjectDiscoveryInterval: config.Duration(time.Second * 300),
|
|
Timeout: config.Duration(time.Second * 20),
|
|
ForceDiscoverOnInit: true,
|
|
DiscoverConcurrency: 1,
|
|
CollectConcurrency: 1,
|
|
Separator: ".",
|
|
HistoricalInterval: config.Duration(time.Second * 300),
|
|
}
|
|
}
|
|
|
|
func createSim(folders int) (*simulator.Model, *simulator.Server, error) {
|
|
model := simulator.VPX()
|
|
|
|
model.Folder = folders
|
|
model.Datacenter = 2
|
|
// model.App = 1
|
|
|
|
err := model.Create()
|
|
if err != nil {
|
|
return nil, nil, err
|
|
}
|
|
|
|
model.Service.TLS = new(tls.Config)
|
|
|
|
s := model.Service.NewServer()
|
|
return model, s, nil
|
|
}
|
|
|
|
func testAlignUniform(t *testing.T, n int) {
|
|
now := time.Now().Truncate(60 * time.Second)
|
|
info := make([]types.PerfSampleInfo, 0, n)
|
|
values := make([]int64, 0, n)
|
|
for i := 0; i < n; i++ {
|
|
info = append(info, types.PerfSampleInfo{
|
|
Timestamp: now.Add(time.Duration(20*i) * time.Second),
|
|
Interval: 20,
|
|
})
|
|
values = append(values, 1)
|
|
}
|
|
e := endpoint{log: testutil.Logger{}}
|
|
newInfo, newValues := e.alignSamples(info, values, 60*time.Second)
|
|
require.Len(t, newInfo, n/3, "Aligned infos have wrong size")
|
|
require.Len(t, newValues, n/3, "Aligned values have wrong size")
|
|
for _, v := range newValues {
|
|
require.InDelta(t, 1.0, v, testutil.DefaultDelta, "Aligned value should be 1")
|
|
}
|
|
}
|
|
|
|
func TestAlignMetrics(t *testing.T) {
|
|
testAlignUniform(t, 3)
|
|
testAlignUniform(t, 30)
|
|
testAlignUniform(t, 333)
|
|
|
|
// 20s to 60s of 1,2,3,1,2,3... (should average to 2)
|
|
n := 30
|
|
now := time.Now().Truncate(60 * time.Second)
|
|
info := make([]types.PerfSampleInfo, 0, n)
|
|
values := make([]int64, 0, n)
|
|
for i := 0; i < n; i++ {
|
|
info = append(info, types.PerfSampleInfo{
|
|
Timestamp: now.Add(time.Duration(20*i) * time.Second),
|
|
Interval: 20,
|
|
})
|
|
values = append(values, int64(i%3+1))
|
|
}
|
|
e := endpoint{log: testutil.Logger{}}
|
|
newInfo, newValues := e.alignSamples(info, values, 60*time.Second)
|
|
require.Len(t, newInfo, n/3, "Aligned infos have wrong size")
|
|
require.Len(t, newValues, n/3, "Aligned values have wrong size")
|
|
for _, v := range newValues {
|
|
require.InDelta(t, 2.0, v, testutil.DefaultDelta, "Aligned value should be 2")
|
|
}
|
|
}
|
|
|
|
func TestConfigDurationParsing(t *testing.T) {
|
|
v := defaultVSphere()
|
|
require.Equal(t, int32(300), int32(time.Duration(v.HistoricalInterval).Seconds()), "HistoricalInterval.Seconds() with default duration should resolve 300")
|
|
}
|
|
|
|
func TestMaxQuery(t *testing.T) {
|
|
if testing.Short() {
|
|
t.Skip("Skipping long test in short mode")
|
|
}
|
|
|
|
m, s, err := createSim(0)
|
|
require.NoError(t, err)
|
|
defer m.Remove()
|
|
defer s.Close()
|
|
|
|
v := defaultVSphere()
|
|
v.MaxQueryMetrics = 256
|
|
c, err := newClient(t.Context(), s.URL, v)
|
|
require.NoError(t, err)
|
|
require.Equal(t, 256, v.MaxQueryMetrics)
|
|
|
|
om := object.NewOptionManager(c.client.Client, *c.client.Client.ServiceContent.Setting)
|
|
err = om.Update(t.Context(), []types.BaseOptionValue{&types.OptionValue{
|
|
Key: "config.vpxd.stats.maxQueryMetrics",
|
|
Value: "42",
|
|
}})
|
|
require.NoError(t, err)
|
|
|
|
v.MaxQueryMetrics = 256
|
|
c2, err := newClient(t.Context(), s.URL, v)
|
|
require.NoError(t, err)
|
|
require.Equal(t, 42, v.MaxQueryMetrics)
|
|
c.close()
|
|
c2.close()
|
|
}
|
|
|
|
func testLookupVM(ctx context.Context, t *testing.T, f *finder, path string, expected int, expectedName string) {
|
|
poweredOn := types.VirtualMachinePowerState("poweredOn")
|
|
var vm []mo.VirtualMachine
|
|
err := f.find(ctx, "VirtualMachine", path, &vm)
|
|
require.NoError(t, err)
|
|
require.Len(t, vm, expected)
|
|
if expectedName != "" {
|
|
require.Equal(t, expectedName, vm[0].Name)
|
|
}
|
|
for i := range vm {
|
|
v := &vm[i]
|
|
require.Equal(t, poweredOn, v.Runtime.PowerState)
|
|
}
|
|
}
|
|
|
|
func TestFinder(t *testing.T) {
|
|
if testing.Short() {
|
|
t.Skip("Skipping long test in short mode")
|
|
}
|
|
|
|
m, s, err := createSim(0)
|
|
require.NoError(t, err)
|
|
defer m.Remove()
|
|
defer s.Close()
|
|
|
|
v := defaultVSphere()
|
|
c, err := newClient(t.Context(), s.URL, v)
|
|
require.NoError(t, err)
|
|
|
|
f := finder{c}
|
|
|
|
var dc []mo.Datacenter
|
|
err = f.find(t.Context(), "Datacenter", "/DC0", &dc)
|
|
require.NoError(t, err)
|
|
require.Len(t, dc, 1)
|
|
require.Equal(t, "DC0", dc[0].Name)
|
|
|
|
var host []mo.HostSystem
|
|
err = f.find(t.Context(), "HostSystem", "/DC0/host/DC0_H0/DC0_H0", &host)
|
|
require.NoError(t, err)
|
|
require.Len(t, host, 1)
|
|
require.Equal(t, "DC0_H0", host[0].Name)
|
|
|
|
host = make([]mo.HostSystem, 0)
|
|
err = f.find(t.Context(), "HostSystem", "/DC0/host/DC0_C0/DC0_C0_H0", &host)
|
|
require.NoError(t, err)
|
|
require.Len(t, host, 1)
|
|
require.Equal(t, "DC0_C0_H0", host[0].Name)
|
|
|
|
resourcepool := make([]mo.ResourcePool, 0)
|
|
err = f.find(t.Context(), "ResourcePool", "/DC0/host/DC0_C0/Resources/DC0_C0_RP0", &resourcepool)
|
|
require.NoError(t, err)
|
|
require.Len(t, host, 1)
|
|
require.Equal(t, "DC0_C0_H0", host[0].Name)
|
|
|
|
host = make([]mo.HostSystem, 0)
|
|
err = f.find(t.Context(), "HostSystem", "/DC0/host/DC0_C0/*", &host)
|
|
require.NoError(t, err)
|
|
require.Len(t, host, 3)
|
|
|
|
var vm []mo.VirtualMachine
|
|
testLookupVM(t.Context(), t, &f, "/DC0/vm/DC0_H0_VM0", 1, "")
|
|
testLookupVM(t.Context(), t, &f, "/DC0/vm/DC0_C0*", 2, "")
|
|
testLookupVM(t.Context(), t, &f, "/DC0/*/DC0_H0_VM0", 1, "DC0_H0_VM0")
|
|
testLookupVM(t.Context(), t, &f, "/DC0/*/DC0_H0_*", 2, "")
|
|
testLookupVM(t.Context(), t, &f, "/DC0/**/DC0_H0_VM*", 2, "")
|
|
testLookupVM(t.Context(), t, &f, "/DC0/**", 4, "")
|
|
testLookupVM(t.Context(), t, &f, "/DC1/**", 4, "")
|
|
testLookupVM(t.Context(), t, &f, "/**", 8, "")
|
|
testLookupVM(t.Context(), t, &f, "/**/vm/**", 8, "")
|
|
testLookupVM(t.Context(), t, &f, "/*/host/**/*DC*", 8, "")
|
|
testLookupVM(t.Context(), t, &f, "/*/host/**/*DC*VM*", 8, "")
|
|
testLookupVM(t.Context(), t, &f, "/*/host/**/*DC*/*/*DC*", 4, "")
|
|
|
|
vm = make([]mo.VirtualMachine, 0)
|
|
err = f.findAll(t.Context(), "VirtualMachine", []string{"/DC0/vm/DC0_H0*", "/DC0/vm/DC0_C0*"}, nil, &vm)
|
|
require.NoError(t, err)
|
|
require.Len(t, vm, 4)
|
|
|
|
rf := resourceFilter{
|
|
finder: &f,
|
|
paths: []string{"/DC0/vm/DC0_H0*", "/DC0/vm/DC0_C0*"},
|
|
excludePaths: []string{"/DC0/vm/DC0_H0_VM0"},
|
|
resType: "VirtualMachine",
|
|
}
|
|
vm = make([]mo.VirtualMachine, 0)
|
|
require.NoError(t, rf.findAll(t.Context(), &vm))
|
|
require.Len(t, vm, 3)
|
|
|
|
rf = resourceFilter{
|
|
finder: &f,
|
|
paths: []string{"/DC0/vm/DC0_H0*", "/DC0/vm/DC0_C0*"},
|
|
excludePaths: []string{"/**"},
|
|
resType: "VirtualMachine",
|
|
}
|
|
vm = make([]mo.VirtualMachine, 0)
|
|
require.NoError(t, rf.findAll(t.Context(), &vm))
|
|
require.Empty(t, vm)
|
|
|
|
rf = resourceFilter{
|
|
finder: &f,
|
|
paths: []string{"/**"},
|
|
excludePaths: []string{"/**"},
|
|
resType: "VirtualMachine",
|
|
}
|
|
vm = make([]mo.VirtualMachine, 0)
|
|
require.NoError(t, rf.findAll(t.Context(), &vm))
|
|
require.Empty(t, vm)
|
|
|
|
rf = resourceFilter{
|
|
finder: &f,
|
|
paths: []string{"/**"},
|
|
excludePaths: []string{"/this won't match anything"},
|
|
resType: "VirtualMachine",
|
|
}
|
|
vm = make([]mo.VirtualMachine, 0)
|
|
require.NoError(t, rf.findAll(t.Context(), &vm))
|
|
require.Len(t, vm, 8)
|
|
|
|
rf = resourceFilter{
|
|
finder: &f,
|
|
paths: []string{"/**"},
|
|
excludePaths: []string{"/**/*VM0"},
|
|
resType: "VirtualMachine",
|
|
}
|
|
vm = make([]mo.VirtualMachine, 0)
|
|
require.NoError(t, rf.findAll(t.Context(), &vm))
|
|
require.Len(t, vm, 4)
|
|
}
|
|
|
|
func TestFolders(t *testing.T) {
|
|
if testing.Short() {
|
|
t.Skip("Skipping long test in short mode")
|
|
}
|
|
|
|
m, s, err := createSim(1)
|
|
require.NoError(t, err)
|
|
defer m.Remove()
|
|
defer s.Close()
|
|
|
|
v := defaultVSphere()
|
|
c, err := newClient(t.Context(), s.URL, v)
|
|
require.NoError(t, err)
|
|
|
|
f := finder{c}
|
|
|
|
var folder []mo.Folder
|
|
err = f.find(t.Context(), "Folder", "/F0", &folder)
|
|
require.NoError(t, err)
|
|
require.Len(t, folder, 1)
|
|
require.Equal(t, "F0", folder[0].Name)
|
|
|
|
var dc []mo.Datacenter
|
|
err = f.find(t.Context(), "Datacenter", "/F0/DC1", &dc)
|
|
require.NoError(t, err)
|
|
require.Len(t, dc, 1)
|
|
require.Equal(t, "DC1", dc[0].Name)
|
|
|
|
testLookupVM(t.Context(), t, &f, "/F0/DC0/vm/**/F*", 0, "")
|
|
testLookupVM(t.Context(), t, &f, "/F0/DC1/vm/**/F*/*VM*", 4, "")
|
|
testLookupVM(t.Context(), t, &f, "/F0/DC1/vm/**/F*/**", 4, "")
|
|
}
|
|
|
|
func TestVsanCmmds(t *testing.T) {
|
|
m, s, err := createSim(0)
|
|
require.NoError(t, err)
|
|
defer m.Remove()
|
|
defer s.Close()
|
|
|
|
v := defaultVSphere()
|
|
c, err := newClient(t.Context(), s.URL, v)
|
|
require.NoError(t, err)
|
|
|
|
f := finder{c}
|
|
var clusters []mo.ClusterComputeResource
|
|
err = f.findAll(t.Context(), "ClusterComputeResource", []string{"/**"}, nil, &clusters)
|
|
require.NoError(t, err)
|
|
|
|
clusterObj := object.NewClusterComputeResource(c.client.Client, clusters[0].Reference())
|
|
_, err = getCmmdsMap(t.Context(), c.client.Client, clusterObj)
|
|
require.Error(t, err)
|
|
}
|
|
|
|
func TestVsanTags(t *testing.T) {
|
|
host := "5b860329-3bc4-a76c-48b6-246e963cfcc0"
|
|
disk := "52ee3be1-47cc-b50d-ecab-01af0f706381"
|
|
ssdDisk := "52f26fc8-0b9b-56d8-3a32-a9c3bfbc6148"
|
|
nvmeDisk := "5291e74f-74d3-fca2-6ffa-3655657dd3be"
|
|
ssd := "52173131-3384-bb63-4ef8-c00b0ce7e3e7"
|
|
hostname := "sc2-hs1-b2801.eng.vmware.com"
|
|
devName := "naa.55cd2e414d82c815:2"
|
|
var cmmds = map[string]cmmdsEntity{
|
|
nvmeDisk: {UUID: nvmeDisk, Type: "DISK_CAPACITY_TIER", Owner: host, Content: cmmdsContent{DevName: devName}},
|
|
disk: {UUID: disk, Type: "DISK", Owner: host, Content: cmmdsContent{DevName: devName, IsSsd: 1.}},
|
|
ssdDisk: {UUID: ssdDisk, Type: "DISK", Owner: host, Content: cmmdsContent{DevName: devName, IsSsd: 0., SsdUUID: ssd}},
|
|
host: {UUID: host, Type: "HOSTNAME", Owner: host, Content: cmmdsContent{Hostname: hostname}},
|
|
}
|
|
tags := populateCMMDSTags(make(map[string]string), "capacity-disk", disk, cmmds)
|
|
require.Len(t, tags, 2)
|
|
tags = populateCMMDSTags(make(map[string]string), "cache-disk", ssdDisk, cmmds)
|
|
require.Len(t, tags, 3)
|
|
tags = populateCMMDSTags(make(map[string]string), "host-domclient", host, cmmds)
|
|
require.Len(t, tags, 1)
|
|
tags = populateCMMDSTags(make(map[string]string), "vsan-esa-disk-layer", nvmeDisk, cmmds)
|
|
require.Len(t, tags, 2)
|
|
}
|
|
|
|
func TestCollectionNoClusterMetrics(t *testing.T) {
|
|
if testing.Short() {
|
|
t.Skip("Skipping long test in short mode")
|
|
}
|
|
|
|
testCollection(t, true)
|
|
}
|
|
|
|
func TestDisconnectedServerBehavior(t *testing.T) {
|
|
u, err := url.Parse("https://definitely.not.a.valid.host")
|
|
require.NoError(t, err)
|
|
v := defaultVSphere()
|
|
v.DisconnectedServersBehavior = "error"
|
|
_, err = newEndpoint(t.Context(), v, u, v.Log)
|
|
require.Error(t, err)
|
|
v.DisconnectedServersBehavior = "ignore"
|
|
_, err = newEndpoint(t.Context(), v, u, v.Log)
|
|
require.NoError(t, err)
|
|
v.DisconnectedServersBehavior = "something else"
|
|
_, err = newEndpoint(t.Context(), v, u, v.Log)
|
|
require.Error(t, err)
|
|
require.Equal(t, `"something else" is not a valid value for disconnected_servers_behavior`, err.Error())
|
|
}
|
|
|
|
func testCollection(t *testing.T, excludeClusters bool) {
|
|
mustHaveMetrics := map[string]struct{}{
|
|
"vsphere.vm.cpu": {},
|
|
"vsphere.vm.mem": {},
|
|
"vsphere.vm.net": {},
|
|
"vsphere.host.cpu": {},
|
|
"vsphere.host.mem": {},
|
|
"vsphere.host.net": {},
|
|
"vsphere.datastore.disk": {},
|
|
}
|
|
vCenter := os.Getenv("VCENTER_URL")
|
|
username := os.Getenv("VCENTER_USER")
|
|
password := os.Getenv("VCENTER_PASSWORD")
|
|
v := defaultVSphere()
|
|
if vCenter != "" {
|
|
v.Vcenters = []string{vCenter}
|
|
v.Username = config.NewSecret([]byte(username))
|
|
v.Password = config.NewSecret([]byte(password))
|
|
} else {
|
|
m, s, err := createSim(0)
|
|
require.NoError(t, err)
|
|
defer m.Remove()
|
|
defer s.Close()
|
|
v.Vcenters = []string{s.URL.String()}
|
|
}
|
|
if excludeClusters {
|
|
v.ClusterMetricExclude = []string{"*"}
|
|
}
|
|
|
|
var acc testutil.Accumulator
|
|
|
|
require.NoError(t, v.Start(&acc))
|
|
defer v.Stop()
|
|
require.NoError(t, v.Gather(&acc))
|
|
require.Emptyf(t, acc.Errors, "Errors found: %s", acc.Errors)
|
|
require.NotEmpty(t, acc.Metrics, "No metrics were collected")
|
|
cache := make(map[string]string)
|
|
client, err := v.endpoints[0].clientFactory.getClient(t.Context())
|
|
require.NoError(t, err)
|
|
hostCache := make(map[string]string)
|
|
for _, m := range acc.Metrics {
|
|
delete(mustHaveMetrics, m.Measurement)
|
|
|
|
if strings.HasPrefix(m.Measurement, "vsphere.vm.") {
|
|
mustContainAll(t, m.Tags, []string{"esxhostname", "moid", "vmname", "guest", "dcname", "uuid", "vmname"})
|
|
hostName := m.Tags["esxhostname"]
|
|
hostMoid, ok := hostCache[hostName]
|
|
if !ok {
|
|
// We have to follow the host parent path to locate a cluster. Look up the host!
|
|
finder := finder{client}
|
|
var hosts []mo.HostSystem
|
|
err := finder.find(t.Context(), "HostSystem", "/**/"+hostName, &hosts)
|
|
require.NoError(t, err)
|
|
require.NotEmpty(t, hosts)
|
|
hostMoid = hosts[0].Reference().Value
|
|
hostCache[hostName] = hostMoid
|
|
}
|
|
if isInCluster(t, v, client, cache, "HostSystem", hostMoid) { // If the VM lives in a cluster
|
|
mustContainAll(t, m.Tags, []string{"clustername"})
|
|
}
|
|
} else if strings.HasPrefix(m.Measurement, "vsphere.host.") {
|
|
if isInCluster(t, v, client, cache, "HostSystem", m.Tags["moid"]) { // If the host lives in a cluster
|
|
mustContainAll(t, m.Tags, []string{"esxhostname", "clustername", "moid", "dcname"})
|
|
} else {
|
|
mustContainAll(t, m.Tags, []string{"esxhostname", "moid", "dcname"})
|
|
}
|
|
} else if strings.HasPrefix(m.Measurement, "vsphere.cluster.") {
|
|
mustContainAll(t, m.Tags, []string{"clustername", "moid", "dcname"})
|
|
} else {
|
|
mustContainAll(t, m.Tags, []string{"moid", "dcname"})
|
|
}
|
|
}
|
|
require.Empty(t, mustHaveMetrics, "Some metrics were not found")
|
|
}
|
|
|
|
func isInCluster(t *testing.T, v *VSphere, client *client, cache map[string]string, resourceKind, moid string) bool {
|
|
ref := types.ManagedObjectReference{
|
|
Type: resourceKind,
|
|
Value: moid,
|
|
}
|
|
_, ok := v.endpoints[0].getAncestorName(t.Context(), client, "ClusterComputeResource", cache, ref)
|
|
return ok
|
|
}
|
|
|
|
func mustContainAll(t *testing.T, tagMap map[string]string, mustHave []string) {
|
|
for _, tag := range mustHave {
|
|
require.Contains(t, tagMap, tag)
|
|
}
|
|
}
|
|
|
|
func TestVersionLowerThan(t *testing.T) {
|
|
tests := []struct {
|
|
current string
|
|
major int
|
|
minor int
|
|
result bool
|
|
}{
|
|
{
|
|
current: "7",
|
|
major: 6,
|
|
minor: 3,
|
|
result: false,
|
|
},
|
|
{
|
|
current: "5",
|
|
major: 6,
|
|
minor: 3,
|
|
result: true,
|
|
},
|
|
{
|
|
current: "6.0",
|
|
major: 6,
|
|
minor: 3,
|
|
result: true,
|
|
},
|
|
{
|
|
current: "6.3",
|
|
major: 6,
|
|
minor: 3,
|
|
result: false,
|
|
},
|
|
{
|
|
current: "6.2",
|
|
major: 6,
|
|
minor: 3,
|
|
result: true,
|
|
},
|
|
{
|
|
current: "7.0.3.0",
|
|
major: 6,
|
|
minor: 7,
|
|
result: false,
|
|
},
|
|
}
|
|
for _, tc := range tests {
|
|
result := versionLowerThan(tc.current, tc.major, tc.minor)
|
|
require.Equalf(t, tc.result, result, "%s < %d.%d", tc.current, tc.major, tc.minor)
|
|
}
|
|
}
|