linux/libnvme
1
0
Fork 0
Code Issues Activity

Adding patch from upstream to fix fd leaks with /sys/bus/pci/slots (Closes: #1043095).

Browse source 
Signed-off-by: Daniel Baumann <daniel@debian.org>
This commit is contained in:
Daniel Baumann 2025-02-16 10:09:31 +01:00
parent 124271b3ac
commit 6fa77cb457
Signed by: daniel
GPG key ID: FBB4F0E80A80222F
2 changed files with 27 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
debian/patches/series vendored Normal file
View file

@ -0,0 +1 @@
upstream/0001-pci-slots-fd-leak.patch

26
debian/patches/upstream/0001-pci-slots-fd-leak.patch vendored Normal file
View file

@ -0,0 +1,26 @@
Author: Martin Belanger <martin.belanger@dell.com>
Description: tree: missing closedir() causes fd leak for "/sys/bus/pci/slots"
In nvme_ctrl_lookup_phy_slot(), we are missing a closedir(), which
causes file descriptors to leak. Also, there was a missing free()
when the function returns with ENOMEM.
diff -Naurp libnvme.orig/src/nvme/tree.c libnvme/src/nvme/tree.c
--- libnvme.orig/src/nvme/tree.c
+++ libnvme/src/nvme/tree.c
@@ -1292,6 +1292,8 @@ static char *nvme_ctrl_lookup_phy_slot(n
ret = asprintf(&path, "/sys/bus/pci/slots/%s", entry->d_name);
if (ret < 0) {
errno = ENOMEM;
+ free(target_addr);
+ closedir(slots_dir);
return NULL;
}
addr = nvme_get_attr(path, "address");
@@ -1306,6 +1308,7 @@ static char *nvme_ctrl_lookup_phy_slot(n
}
}
free(target_addr);
+ closedir(slots_dir);
if (found)
return strdup(entry->d_name);
return NULL;